Remove default for transformation algorithm#410
Merged
cjbarth merged 1 commit intonode-saml:masterfrom Nov 13, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
==========================================
- Coverage 73.55% 73.36% -0.20%
==========================================
Files 9 9
Lines 900 901 +1
Branches 239 239
==========================================
- Hits 662 661 -1
- Misses 141 142 +1
- Partials 97 98 +1
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the default transformation algorithm, forcing the consumer to choose the one that they want. This is an attempt to address #376.
I've also reviewed the README to update a few things that were missed in previous PR removing defaults.